Editing Dark Mode Suggestions
Jump to navigation
Jump to search
The edit can be undone. Please check the comparison below to verify that this is what you want to do, and then publish the changes below to finish undoing the edit.
Latest revision | Your text | ||
Line 75: | Line 75: | ||
********** Im reading my previous comment and im not sure sure if i was clear, to summarize, the problem we have right now is the <nowiki><pre>, <code>, <source></nowiki> (deprecated) and some more tags are inheriting the colors from the syntaxhighlights settings, you already know this because we was talking about it in [[User_talk:Derf]]. The syntaxhighlights settings contains 75 colors (repeated many times) that was supposed to work fine with a bright background and we changed 3 of them to improve readability over bright backgrounds a bit more. Well... the only way to have a nice color selection for dark backgrounds is to replace most/all the syntaxhighlight colors, is not just the background, is needed to replace a lot more colors (remember i leave a link with a dark color setup in your tak page). The alternative (or better said... the easy way) is to dont change any color in the dark skin. #303841 probably is too bright, the comments in most languages have a middle grey color close to that --[[User:Sandungas|Sandungas]] ([[User talk:Sandungas|talk]]) 12:32, 17 June 2023 (CEST) | ********** Im reading my previous comment and im not sure sure if i was clear, to summarize, the problem we have right now is the <nowiki><pre>, <code>, <source></nowiki> (deprecated) and some more tags are inheriting the colors from the syntaxhighlights settings, you already know this because we was talking about it in [[User_talk:Derf]]. The syntaxhighlights settings contains 75 colors (repeated many times) that was supposed to work fine with a bright background and we changed 3 of them to improve readability over bright backgrounds a bit more. Well... the only way to have a nice color selection for dark backgrounds is to replace most/all the syntaxhighlight colors, is not just the background, is needed to replace a lot more colors (remember i leave a link with a dark color setup in your tak page). The alternative (or better said... the easy way) is to dont change any color in the dark skin. #303841 probably is too bright, the comments in most languages have a middle grey color close to that --[[User:Sandungas|Sandungas]] ([[User talk:Sandungas|talk]]) 12:32, 17 June 2023 (CEST) | ||
*********** Is it just me or why we can't just keep the same color like on standard mode, which is #F3F4F5. It would fix all problems. [[User:Roxanne|Roxanne]] ([[User talk:Roxanne|talk]]) - 17th June 2023 - 13:58 GMT+1 | *********** Is it just me or why we can't just keep the same color like on standard mode, which is #F3F4F5. It would fix all problems. [[User:Roxanne|Roxanne]] ([[User talk:Roxanne|talk]]) - 17th June 2023 - 13:58 GMT+1 | ||
************ Well, this is one of the cases where i prefer to "do it well" or dont do it at all, and i think is a bad timing to enter in this forest specially because the syntaxhighligh color settings for vector skin was not fully reviewed (we just changed 3 colors but it can be made way better). Im reviewing the talk in derf user page and the way to do it right is by adding a lot of '''<code>.client-dark-mode .mw-highlight .s {color:WHATEVER}</code>'''<br> (in this example the .s changes the color for "strings" data types inside the highlighted code), i mentioned above that are up to 75 colors, but in derf tak page i counted only 11 colors because a lot of them are repeated (in the same way we can group them to change them in groups for the dark skin), anyway for reference of how many colors we need to modify take a look at this [https://myridia.com/dev_posts/view/2125] ( | ************ Well, this is one of the cases where i prefer to "do it well" or dont do it at all, and i think is a bad timing to enter in this forest specially because the syntaxhighligh color settings for vector skin was not fully reviewed (we just changed 3 colors but it can be made way better). Im reviewing the talk in derf user page and the way to do it right is by adding a lot of '''<code>.client-dark-mode .mw-highlight .s {color:WHATEVER}</code>'''<br> (in this example the .s changes the color for "strings" data types inside the highlighted code), i mentioned above that are up to 75 colors, but in derf tak page i counted only 11 colors because a lot of them are repeated (in the same way we can group them to change them in groups for the dark skin), anyway for reference of how many colors we need to modify take a look at this [https://myridia.com/dev_posts/view/2125] (seems to be a "port" of [https://github.com/tanvirtin/monokai.nvim] skin for linux terminal and looks really nice). Thats the better way to do it by replacing pretty much all the syntaxhighlight colors --[[User:Sandungas|Sandungas]] ([[User talk:Sandungas|talk]]) 14:15, 17 June 2023 (CEST) | ||
=== Example 4 === | === Example 4 === | ||
Line 128: | Line 128: | ||
|- | |- | ||
| style="border-bottom:hidden; border-left:hidden; background:rgba(0,0,0,0)" | 3/1 || 3/2 || style="border-bottom:hidden; border-right:hidden; background:rgba(0,0,0,0)" | 3/3 | | style="border-bottom:hidden; border-left:hidden; background:rgba(0,0,0,0)" | 3/1 || 3/2 || style="border-bottom:hidden; border-right:hidden; background:rgba(0,0,0,0)" | 3/3 | ||
|} | |} | ||
Line 160: | Line 154: | ||
* What settings do you want me to set? [[User:Derf|Derf]] ([[User talk:Derf|talk]]) 04:50, 17 June 2023 (CEST) | * What settings do you want me to set? [[User:Derf|Derf]] ([[User talk:Derf|talk]]) 04:50, 17 June 2023 (CEST) | ||
** Is a property inherited from the wikitable class and needs to match with the color you setted for the .mw-datatable td. Im not sure if there is a less intrusive way to do it but this should fix the phantom border --[[User:Sandungas|Sandungas]] ([[User talk:Sandungas|talk]]) 12:52, 17 June 2023 (CEST) | ** Is a property inherited from the wikitable class and needs to match with the color you setted for the .mw-datatable td. Im not sure if there is a less intrusive way to do it but this should fix the phantom border --[[User:Sandungas|Sandungas]] ([[User talk:Sandungas|talk]]) 12:52, 17 June 2023 (CEST) | ||
'''<code>.client-dark-mode .wikitable{background-color:black | '''<code>.client-dark-mode .wikitable{background-color:black}</code>'''<br> | ||
And this should fix both problems by replacing the black font by white (or whatever other color you used for fonts)<br> | And this should fix both problems by replacing the black font by white (or whatever other color you used for fonts)<br> | ||
'''<code>.client-dark-mode .wikitable{background-color:black | '''<code>.client-dark-mode .wikitable{background-color:black; color:white;}</code>''' | ||
=== Header sorting arrows images === | === Header sorting arrows images === | ||
Line 174: | Line 168: | ||
== Link Colors == | === Link Colors === | ||
The gold color that all links currently are is arbitrary. It looked good on the ConsoleMods theme, but it definitely can be different here. | The gold color that all links currently are is arbitrary. It looked good on the ConsoleMods theme, but it definitely can be different here. | ||
Line 194: | Line 188: | ||
} | } | ||
*cornflowerblue looks nice, im fully into keeping the links in a blue tone, either cornflowerblue or something close to it (yellows and oranges fits better for page section titles and things that are not clickables.. and red for errors and broken links) --[[User:Sandungas|Sandungas]] ([[User talk:Sandungas|talk]]) 13:50, 17 June 2023 (CEST) | *cornflowerblue looks nice, im fully into keeping the links in a blue tone, either cornflowerblue or something close to it (yellows and oranges fits better for page section titles and things that are not clickables.. and red for errors and broken links) --[[User:Sandungas|Sandungas]] ([[User talk:Sandungas|talk]]) 13:50, 17 June 2023 (CEST) | ||